Johannes Altmanninger

Results 734 comments of Johannes Altmanninger

why not use grep: fish -c "fish_trace=1 ls" &| grep '^--->'

Great, thanks! This seems like an obvious improvement. I did some testing on a repository where I'm some commits ahead and behind of `@{upstream}`. I think we need pass the...

Yeah, I think it's okay to error out if `HEAD` and `upstream` have no common ancestor. Git rebase has `--root` to deal with root commits but that's probably not very...

fixed in latest master, see https://github.com/torbiak/git-autofixup/pull/19

@torbiak we've been happily using this performance fix for around a year, how do you feel about merging it? Also #18 is a nice improvement.

I think it's fine to rely on `%val{hook_param}` being defined. In shell blocks we can check this by testing if `${kak_hook_param+x}` is non-empty. Outside shell blocks it's also fairly simple:...

OK, added some docs (which are also applicable to the old behavior, since this is really just an optimization)

this still gives a decent speed up of 1.8 (even 2.6 when applied after another regex optimization that finds required substrings). But adding the special case is a bit ugly...

This current patch has a bad performance regression when navigating very long lines. Didn't look into it yet. Probably it messes with cache keys.

Similar thing happens for `%arg{@}` - it's not available as `$@` in pipe commands, hence 13948ecb941a4a684cc1ed29f903af54684c1378 added a workaround Sounds like we should fix this though I haven't looked at...