Kai Dorschner comments

Results 60 comments of


Kai Dorschner

Problems with .isValid() on required checkboxes

But [L27](https://github.com/Knockout-Contrib/Knockout-Validation/blob/2.0.3/src/rules.js#L27) is a shortcut and will return with `false` if `required === true`. I'd rather prefer to do another type check as in [L32](https://github.com/Knockout-Contrib/Knockout-Validation/blob/2.0.3/src/rules.js#L32): ``` js if (typeof (val)...

Problems with .isValid() on required checkboxes

Alright thanks, I'll do a PR. Should I also build the dist?

Problems with .isValid() on required checkboxes

Any news here?

Problems with .isValid() on required checkboxes

Not anymore.

cannot customize style of ng-select in Angular

Same issue here. This is due to the local scoped scss of the component which will always have a higher specificity than the global style definitions.

Bower support + Firefox NX source download bug

1. Yes, someone will have to register it, preferably @solkimicreb 2. GA? 3. no it takes up 96kb 4. As soon as Shadow DOM and Proxies are implemented or polyfilled...

Fix endDate trigger; add config options for period labels; trigger change for month-select, year-select, decade-select.

What a pitty. This lib is so cool, but doesn't get this truly nice PR merged :(

iOS 6-7 handles viewport relative units really weird

Seems to be fixed in IOS 8, we can't reproduce it there. https://github.com/rodneyrehm/viewport-units-buggyfill fixed it for IOS < 8

Add FunctionComponent matcher

Nice :) Will do!

Add FunctionComponent matcher

I added `SFC` and `FC` but tbh I don't understand how to write your `componentReader` tests :D any support on this? Create new files or extend existing ones?