Add support for accent color saturation level
This new version allows you to use any accent color, such as gray, brown, etc. Designed to colorize the default Windows 11 visual style and Rectify11's custom visual styles. Does not have the Windows version checks apart from the taskband ExtendedUI buttons.
This does not mean it does not work on Windows Vista to 10, in fact, it should work as intended. My main concern was Windows 11.
I just realized that we forked the project almost at the same time lol.
@OrthodoxWindows Try out my new version, you'll like it.
@OrthodoxWindows Try out my new version, you'll like it.
Indeed, your changes fix all the problems I was having. Thank you very much.
However, I still see one element not colorized ; these are some frames related to the Basic theme (if you use the Basic theme with DWM, you have to use this Windhawk mod to enable them) in the Aerolite style :
For some reason, in the Aero style, it seems to be colorized correctly :
@krlvm This one has full HSL support, meaning the bitmaps change according to the different brightness levels of accent colors. It fully works on the Rectify11 visual styles (light and dark), but on the Microsoft ones (Windows 10/11), the Explorer list views do not support all colors and may turn into weird colors. I thought it was the transparent pixels but they colorize perfectly with the Rectify11 styles. I tried multiplying the saturation by 0.9 and that workaround works but the colors are more inaccurate.
This is still very cool, I'll think about how I can help this evening and we'll merge it into the upstream
Have you checked the code?
Currently it breaks with light orange color:
(just for record, will check what we can do with it)
Interestingly enough, the correct colors show up if you have the items grouped and click the expand/collapse button. They only show up when the animation is playing, when it finishes, the broken color comes back.
Interestingly enough, the correct colors show up if you have the items grouped and click the expand/collapse button. They only show up when the animation is playing, when it finishes, the broken color comes back.
The (almost) correct color is also applied to the ListView items focused state
Does this fix the color issue?
Yes, it works much better. Thank you!
However, if you set accent color back to Standard Blue, everything looks undersaturated in comparasion to the default colors - where did you get g_hslDefaultAccent values from?
This is almost perfect, its only bug is when the theme is changed, it applies a weird light gray color and changing the accent color to a normal one gives wrong lightness values and gradients are completely ruined.
Oh and I also forgot to restore the menu/progress bar checks since this is aimed at Rectify11.
@krlvm I think we should make the program restart itself when WM_THEMECHANGED is sent but I don't know how to do that.
Oh and I also forgot to restore the menu/progress bar checks since this is aimed at Rectify11.
Do you plan to fix the issue with some Basic window frames in the Aerolite style ? (as I described above)
@OrthodoxWindows Aerolite uses a fillcolor for that frame which AccentColorizer cannot colorize. It can only colorize bitmaps.
@krlvm Have you figured out why theme changing is broken?
I will check soon, thank you
Update: I got hue and saturation, but lightness is still not accurate. Gradients are smooth which means the lightness proportions are correct.
Update 2: It's now fixed! (though it seems to work when I build it as debug only)
~It also works when I build it as Release Static... why is Release broken?~ Doesn't work after a few theme changes as well.
@krlvm Any update? If you can make it work on Release just like how it does on Debug, then we can ship it
I'll check it now, thanks
Did you mean launching Release builds or running it? There was a mistake in the build configuration, which prevented Release builds from being launched from VS.
As for the results, I don't see any difference from Debug.
It's as if there is no idempotency now - after each restart of the program the colors become darker and darker.
It's as if there is no idempotency now - after each restart of the program the colors become darker and darker. What do you do to get the colors darker?
I just kill and start the process again, so it recolorizes everything one more time
You can also change accent colors back and forth a few times and then check the produced color with a graphics editor - it will change
I just kill and start the process again, so it recolorizes everything one more time
Yes, I have not addressed this issue. I always assumed users would start it once until they restart the device (which resets bitmaps back to default colors). I guess we can save the g_oldhslAccentS and g_oldhslAccentL values get saved in a way that is preserved even if AccentColorizer is not running?