Kirill Müller comments

Results 2418 comments of


                                            Kirill Müller

sample.size default

From https://github.com/igraph/rigraph/pull/1602#discussion_r2000607282: > Should we leave deprecated functions unchanged? To be clear: I don't think we should ever touch deprecated functions. Just ensure they are as stable as we can...

clickable url issues

To fix this, we'd need a class for strings that contain URLs. I don't find one in https://github.com/krlmlr/awesome-vctrs/, but perhaps there is one? We could then use link texts for...

Expose widest paths functions

🤖 This issue has been assigned to Copilot for automated handling.

De-couple class from sql translation

I like the initiative, only minor remarks: - `supports_table_alias_with_as` and `supports_window_clause` : I don't understand what's special about these, compared to, e.g., the translations. Why not also store the translations...

Avoid `.Call()` in code other than `aaa-auto.R`

We can call `rlang::arg_match()` in the manual wrapper in such cases, before forwarding to `_impl()`.

Avoid `.Call()` in code other than `aaa-auto.R`

Scratch that, we probably need `igraph.match.arg()` also in the manual wrapper.

Avoid `.Call()` in code other than `aaa-auto.R`

It's a case-insensitive version of `match.arg()`, and `rlang::arg_match()` is a version of that with better behavior and error messages.

Avoid `.Call()` in code other than `aaa-auto.R`

Now using the new `switch_igraph_arg()` for translating enums (=R strings) to integers.

Error when using `tibble::as_tibble()` interactively not reproducing in `reprex::reprex()`

Thanks. When you run interactively, what do you see with `getOption("width")` ? Can you replicate with a reprex by setting the corresponding width?

Error when using `tibble::as_tibble()` interactively not reproducing in `reprex::reprex()`

Thanks. I see the error in Positron too.