Kirill Müller comments

Results 2418 comments of


                                            Kirill Müller

feat: Pull as part of finalize_version()

Thanks. `pull = FALSE` is required if offline. I'm not sure we need it for the lower-level functions such as `commit_version()` .

feat: Pull as part of finalize_version()

I'd wrap that code in a function and call it only from `finalize_version()`, perhaps. Rethinking offline work. If we're offline, or if PATs are unset, everything should still work, but...

Tag and check for release candidates

I'm moving towards bumping the version with each attempted release. It's also recommended practice by CRAN.

Tag and check for release candidates

Numbers are cheap. We might support both ways, it's low priority at the moment.

Tag and check for release candidates

/style

Tag and check for release candidates

/merge

Tag and check for release candidates

No.

Tag and check for release candidates

/merge

Tag and check for release candidates

I'm experimenting with a flow that allows seamless integration of the target branch into the source branch. I do wonder why GitHub hasn't implemented this yet. Anyway, this is now...

Tag and check for release candidates

I'm open to discussing release candidate tags. About to merge that long-running PR, this will probably close this PR.