cerberus icon indicating copy to clipboard operation
cerberus copied to clipboard

Update start_cerberus.py

Open seanogor opened this issue 3 years ago • 5 comments

solving oc issue

Description

#133

Fixes

dropped in oc, removed -r option in sed as it didn't work on a mac but that can be put back in if necessary

seanogor avatar May 06 '21 18:05 seanogor

Can one of the admins verify this patch?

comet-perf-ci avatar May 06 '21 18:05 comet-perf-ci

/rerun all

chaitanyaenr avatar May 06 '21 21:05 chaitanyaenr

Test Result Duration
test_daemon_disabled Pass 00:00:06
test_detailed_data_inspection Fail 00:00:39
test_slack_integration Pass 00:00:47
Check Gold time (s) PR time (s) % Change

comet-perf-ci avatar May 06 '21 21:05 comet-perf-ci

Im happy with that, was only changing for consistency... kubectl on the second command is fine

On Thu, 6 May 2021, 22:33 Naga Ravi Chaitanya Elluri, < @.***> wrote:

@.**** commented on this pull request.

In start_cerberus.py https://github.com/cloud-bulldozer/cerberus/pull/135#discussion_r627778685 :

         logging.info("\n%s" % (cluster_version))
  •    cluster_info = runcommand.invoke("kubectl cluster-info | awk 'NR==1' | sed -r "
    
  •    cluster_info = runcommand.invoke("oc cluster-info | awk 'NR==1' | sed "
    

@seanogor https://github.com/seanogor we might want to use kubectl here since cluster-info resource is common to both kubernetes as well openshift distributions. This way it works even when the distribution is set to kubernetes. Thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cloud-bulldozer/cerberus/pull/135#pullrequestreview-653913584, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB74KG2ZH2SRRKA5NTUZ6CTTMMDMBANCNFSM44HU5I2Q .

seanogor avatar May 07 '21 06:05 seanogor

Taking out the -r option didn't work for me. I'm also on a mac

2021-05-07 12:21:04,506 [INFO] Encountered issues in cluster. Hence, setting the go/no-go signal to false
2021-05-07 12:21:04,506 [INFO] Exception: No connection adapters were found for '\x1b[0;33mhttps://api.qe-pr-az48.qe.azure.devcluster.openshift.com:6443\x1b[0m/healthz'

paigerube14 avatar May 07 '21 16:05 paigerube14