nodules icon indicating copy to clipboard operation
nodules copied to clipboard

Published 20 hours ago • verified publisher icon kriszyp

binary modules

Open dvv opened this issue 14 years ago • 4 comments

Binary modules can't be require()d since nodules adds .js suffix to module name. If I make a symlink ln -s binmodule binmodule.js to simulate vanilla module, I get rker){ELF ^ SyntaxError: Unexpected token ILLEGAL at /home/dvv/NODE/nodules/lib/nodules.js:5:18 at createFactory (/home/dvv/NODE/nodules/lib/nodules.js:558:20) at /home/dvv/NODE/nodules/lib/nodules.js:418:7 at /home/dvv/NODE/nodules/lib/nodules-utils/promise.js:299:10 at Function.ensure (/home/dvv/NODE/nodules/lib/nodules.js:400:11) at /home/dvv/NODE/nodules/lib/nodules.js:544:15 at String.replace (native) at /home/dvv/NODE/nodules/lib/nodules.js:542:12 at /home/dvv/NODE/nodules/lib/nodules-utils/promise.js:299:10 at /home/dvv/NODE/nodules/lib/nodules.js:540:10

Please, consider fixing

TIA, --Vladimir

dvv avatar Oct 23 '10 17:10 dvv

Aren't binary modules supposed to end in .node? Nodules looks for .node binary modules.

kriszyp avatar Oct 24 '10 01:10 kriszyp

Hmmm. I failed to use node-mongodb-native with native bson module compiled. It is called bson.node but still doesn't get loaded

dvv avatar Oct 24 '10 06:10 dvv

More specific: http://gist.github.com/643545 What should I add to package.json so that native parser got correctly loaded?

TIA

dvv avatar Oct 24 '10 13:10 dvv

Found the bug: http://github.com/kriszyp/nodules/blob/master/lib/nodules.js#L794 should reference fs, not file

Please, consider fixing

--Vladimir

dvv avatar Oct 24 '10 14:10 dvv