Kris West

Results 489 comments of Kris West

@mhmcclung when you're back from vacation could you look at this again? It is resolved for this case: `let response = await fdc3.open({appId: "ThisAppDoesNotExist"})` - based on `appIdentifier`/`appId` but not...

> What is the expected behaviour when raising a CreateNotification intent multiple times with the same id.notificationId value? Update the notification if one with that id exists? > > And...

@robmoffat we've tested up a solution from the workbench audit issues (all are from its use of create-react-app). I'll find some time to raise a PR with the fixes this...

> awesome, well done Kris! Credit to @julianna-ciq whose NPM/React/Webpack-fu is stronger than mine ;-)

For the last CVE, do we care about the development server from create-react-app? Definitely not a production dependency. The other CVE is marked 'high' but has questionable info associated with...

LGTM Types will need regenerating, but that can be done (perhaps needs to be?) post merge to master.

@robmoffat uses https://about.codecov.io/ for spring bot's code coverage (free for opensource)

@pgn-vole This is covered in the [Desktop Agent overview under Register an Intent Handler](https://fdc3.finos.org/docs/api/spec#register-an-intent-handler) > ### Register an Intent Handler > Applications need to let the system know the intents...