assetic icon indicating copy to clipboard operation
assetic copied to clipboard

Circular dependencies in LESS imports cause AssetFactory::getLastModified() to enter an infinite loop

Open LukeTowers opened this issue 6 years ago • 4 comments

AssetFactory->getLastModified() does not take into account circular dependencies when attempting to get the lastModified time for the provided asset using dependency resolving. If loopstart.less imports loopstep.less and loopstep.less includes loopstart.less; then it will result in an infinite loop when trying to get the last modified time for the tree as a whole.

loopstart.less

@import "loopstep.less";

loopstep.less

@import "loopstart.less";

LukeTowers avatar Apr 18 '18 22:04 LukeTowers

@dunets I'm glad I was able to provide some amusement for you 😝 😄

LukeTowers avatar Jul 06 '18 16:07 LukeTowers

@jaxwilko this is the issue I was talking about. Could you see if it still happens with the wikimedia package we're using instead?

LukeTowers avatar Feb 05 '20 18:02 LukeTowers

@jaxwilko did you ever get a chance to see if this is still present in wikimedia?

LukeTowers avatar Oct 11 '20 07:10 LukeTowers

@LukeTowers I think I had a look but I can't remember what the outcome was

jaxwilko avatar Oct 11 '20 11:10 jaxwilko