assetic icon indicating copy to clipboard operation
assetic copied to clipboard

fix allowing inclusion of functions.php multiple time

Open tgloeggl opened this issue 10 years ago • 2 comments

The current usage of function_exists does not allow for multiple inclusion of functions.php, see http://php.net/manual/de/function.function-exists.php#110163

The diff is a bit messy, i simply negated the if-call, put all functions into the if block and corrected the indentation.

tgloeggl avatar Nov 05 '15 14:11 tgloeggl

@tgloeggl please resubmit this to the 2.0 branch of assetic-php/assetic. @jaxwilko if @tgloeggl doesn't want to, could you implement this?

LukeTowers avatar Feb 05 '20 18:02 LukeTowers

@tgloeggl please resubmit this to the 2.0 branch of assetic-php/assetic. @JaxWilko if @tgloeggl doesn't want to, could you implement this?

I would gladly but that does not seem to be necessary in that mentioned branch as all functions are separately gated (instead of my lazy variant of that) and multiple inclusions of functions.php should not result in an error anymore.

tgloeggl avatar Feb 13 '20 14:02 tgloeggl