preact-hn icon indicating copy to clipboard operation
preact-hn copied to clipboard

Published 20 hours ago • verified publisher icon kristoferbaxter

Tracking

Open kristoferbaxter opened this issue 7 years ago • 5 comments

https://github.com/lukeed/ganalytics/blob/master/src/index.js

  1. Modify to use per-browser builds
  2. Use Object.assign since it's polyfilled for fallbacks.

kristoferbaxter avatar Jul 24 '17 20:07 kristoferbaxter

The library now ships with Object.assign 👍

lukeed avatar Jul 26 '17 19:07 lukeed

Nice! Will try to take a look this week.

kristoferbaxter avatar Jul 27 '17 01:07 kristoferbaxter

Work ongoing: https://github.com/kristoferbaxter/preact-hn/tree/typescript

kristoferbaxter avatar Sep 07 '17 18:09 kristoferbaxter

Was a lack of something keeping you from using it directly?

lukeed avatar Sep 07 '17 19:09 lukeed

https://github.com/kristoferbaxter/preact-hn/blob/typescript/src/core/analytics.ts

Three items –

  1. Wanted to add some type safety
  2. Use Browser based builds to check DNT per platform
  3. Leverage URL/URLSearchParams directly (since they're polyfilled for devices without support).

kristoferbaxter avatar Sep 08 '17 18:09 kristoferbaxter