kjosturett-web icon indicating copy to clipboard operation
kjosturett-web copied to clipboard

Fix various issues with the current implementation

Open hauxir opened this issue 1 year ago • 1 comments

  • Take into account answers that are 0 in results -- major issue, Mjög óssammála ignored in results
  • Prevent null! being stored as a string when marking a question as important by setting it as 2 by default
  • Fix off by one error where 3 was assumed to be neutral when in reality it is 2

hauxir avatar Oct 25 '24 15:10 hauxir

Looks good! Only thing I am wondering is that we are going to modify the scale so instead of 5 point scale we go to a 4 point scale and include "skip", basically making it a 5 point scale. So this might need to reflect that changes as well?

That change is being implemented here https://github.com/kristjanmik/kjosturett-web/pull/74

axelg12 avatar Oct 26 '24 11:10 axelg12

This should now be fixed with the latest release

axelg12 avatar Nov 04 '24 12:11 axelg12

Closing as this has already been implemented with the new SVT solution

axelg12 avatar Nov 14 '24 22:11 axelg12