vim-dadbod-ui icon indicating copy to clipboard operation
vim-dadbod-ui copied to clipboard

fix: stop overriding `list` in query files

Open ss-raicangu opened this issue 6 months ago • 0 comments

Concerns

  • [ ] Should I revert (or rebase-drop) 296374a (refactor: set filetype after other options, 2024-08-07)?
    • This is a bit beyond what you suggested but I thought it'd be useful for people who prefer line-wrapping (for example).

Description

Resolves #267.

commit 296374af294d41a2ea15017adb9c2ee146ee5f6c
Author: ss-raicangu <[email protected]>
Date:   2024-08-07T23:07:24+12:00

    refactor: set `filetype` after other options
    
    This allows filetype plugins, such as `mysql.vim`, to override any of
    the special query buffer settings if needed.
    
    A similar pattern of setting `filetype` before other settings is present
    for the DBUI drawer. I assume this is more deliberate, and is out of
    scope for kristijanhusak/vim-dadbod-ui#267, so I haven't changed this
    part.
    
    This change was not signed off, so might be reverted.
    
    BREAKING-CHANGE: Options set in filetype plugins are now preferred for
                     query buffers.
    Link: https://github.com/kristijanhusak/vim-dadbod-ui/blob/0f51d8de368c8c6220973e8acd156d17da746f4c/autoload/db_ui/drawer.vim?plain=1#L38

commit 607d1c17bf5245553e7b20a277c951f664acaf92
Author: ss-raicangu <[email protected]>
Date:   2024-08-07T22:57:22+12:00

    fix: stop overriding `list` in query files
    
    Problem: `list`-mode characters are not being shown in `dadbod-ui` query
             buffers and the filetype plugin setting is always being
             overridden.
    Solution: Remove `nolist` after `setlocal filetype`, so that the `list`
              preference is honoured.
    Signed-off-by: Kristijan Husak <[email protected]>

ss-raicangu avatar Aug 07 '24 11:08 ss-raicangu