lowdown icon indicating copy to clipboard operation
lowdown copied to clipboard

Added Support for building on Mac OS with Clang

Open SZanko opened this issue 2 years ago • 1 comments

fix: Can be compiled on Mac OS with the default system compiler(clang)

Why: Clang doesn't know the soname linker flag instead the install_name flag is used

How: Added LINKER_SONAME_OPTION option to configure script that can be set manually and will be set if the CC env is clang

Tags: Clang Support, Mac OS build support,

Signed-off-by: SZanko [email protected]

SZanko avatar Mar 16 '22 13:03 SZanko

I think we can use the shared-library OS X format instead of the UNIX-like format. This requires replacing the -shared with -dynamiclib option and file suffix .so with .dylib.

See Creating Dynamic Libraries.

judaew avatar May 29 '22 21:05 judaew

Looks like there's some overlap in our PRs -> https://github.com/kristapsdz/lowdown/pull/108

Any update on getting one of these through?

ddustin avatar Dec 30 '22 19:12 ddustin

This has been fixed in commit 0fb3e8f, which incorporates some modifications in oconfigure specific to this issue. Thank you again everybody, and I'm sorry for taking so long!

(I'll tag out a release in the next day or so that incorporates this and other pull requests.)

kristapsdz avatar Mar 26 '23 18:03 kristapsdz