nestjs-dataloader icon indicating copy to clipboard operation
nestjs-dataloader copied to clipboard

Validate if GraphQL Context exists for another Execution Contexts

Open dantehemerson opened this issue 4 years ago • 6 comments

Fix #22 Since the interceptor is injecting globally, we must validate that the GraphQL context exists.

dantehemerson avatar May 16 '20 20:05 dantehemerson

Pull Request Test Coverage Report for Build 106805450

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 83.333%

Totals Coverage Status
Change from base Build 103164194: 1.2%
Covered Lines: 20
Relevant Lines: 22

💛 - Coveralls

coveralls avatar May 16 '20 20:05 coveralls

Pull Request Test Coverage Report for Build 106805450

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 83.333%

Totals Coverage Status
Change from base Build 103164194: 1.2%
Covered Lines: 20
Relevant Lines: 22

💛 - Coveralls

coveralls avatar May 16 '20 20:05 coveralls

@krislefeber can you please merge it? It's happening to us as well. We are not able to move fwd. By the way, love the package & thanks for all the effort 🎉

hamxabaig avatar Oct 14 '20 06:10 hamxabaig

Screenshot 2020-10-14 at 11 38 46 AM

@krislefeber getting error due to this, please merge this PR. Thanks

junaidcs avatar Oct 14 '20 06:10 junaidcs

Let's merge it

vinhnguyen1211 avatar Oct 14 '20 08:10 vinhnguyen1211

Hi folks. Seems that this repository has not been maintained for a long time. So in the meantime, I have created a new repository to add this feature.

The fix version is: https://github.com/dantehemerson/nestjs-dataloader/releases/tag/v1.0.1 Npm Package: https://www.npmjs.com/package/@dantehemerson/nestjs-dataloader You can install it by doing: npm i @dantehemerson/nestjs-dataloader

dantehemerson avatar May 21 '22 22:05 dantehemerson