wisper
wisper copied to clipboard
krisleech
Ruby 3 compat drop 2.6
Continuing from the original PR krisleech/wisper#192 to add support for Ruby 3.0, this PR simply takes work done by @doits and direction from the most recent comment and attempts to make the requested changes.
Specifically this branch excludes support for ruby 2.6: master...doits:b86c57d6064495ef67391405e517dbe85b622d8c
I also reverted the changes around travis / github actions config.
From original PR for context: krisleech/wisper#192 Fixes: krisleech/wisper#190
Makes use of **kwargs everywhere so it is compatible with ruby 3.
Unfortunately this does not work with ruby 2.6 and below, so I dropped it. It could be made to work with 2.6 by using ruby2_keywords, but I assumend support for 2.6 is not a priority for this gem.
Another thing is I don't know how this works with jruby, e.g. if ruby mri 3 and the use of **kword is compatible to jruby or not.
I hope I didn't miss a place to convert to kword args.
@krisleech Does this work (on top of https://github.com/krisleech/wisper/pull/192) seem OK to you for a new release? Would be happy to help get things over the line for a new major release.
I'm happy to take direction on any additional testing or changes that are required.
As we're hoping to update our Rails app to Ruby 3 soon and add wisper it'd be great if this could get merged 🍾
@oskarpearson I appreciate the feedback and fwiw I think you're right.
However, I'm no longer working on the project that uses this gem or ruby at all for that matter. I'm going to close this out, but by all means feel free to take it over yourself.