Kris Leech comments

Results 64 comments of


                                            Kris Leech

nil.params when using from console

I also get this issue, would you recommend "vendoring" the gem and applying this patch... Any chance of this patch getting applied?

Singleton Matcher

Is this backwards compatible in terms of what the `broadcast` can do? Can you update the README and CHANGELOG files please.

Use the new Wisper::Testing gem to provide faking of events based on rspec tags

Would be better to add this code directly to this gem since it is related only to RSpec.

Include attributes that have changed along with the model

This is a good idea. I was also thinking we should change the first argument to `self.id` (only for the second broadcast) as well since `self` will not work for...

Include attributes that have changed along with the model

I don't think so, other than the gem linked to above, which I haven't tried myself. But you can do this with plain wisper events. Call `broadcast` from a ActiveRecord...

Bump to 1.1.0: Add new callback methods

Thanks for this! Can you tell me a bit about the use case for broadcasting in the `before` callbacks? It looks like the specs are failing for ActiveRecord 3.0 because...

Specify story id to work on

Don't add `config.expose_dsl_globally = false` when there's `config.disable_monkey_patching!`

Is this needed? When I have `disable_monkey_patching!` then `describe` is an undefined method.

rbx 2.3 fails to build on Yosemite due to llvm config error

rbx (~> 2.5) needs an older LLVM (~> 3.5) then is installed by latest xcode or brew. Check the system LLVM is okay or you have an older brew installed...

Rails 5 generating deprecation warning when using strong parameter

You can do this in your Virtus model: ```ruby def initialize(attributes) super(attributes.to_h) end ```