wanderlust icon indicating copy to clipboard operation
wanderlust copied to clipboard

[BUG] All posts card is not inline with the skeleton (shimmer card)

Open krishnaacharyaa opened this issue 11 months ago • 12 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

image image

Expected Behavior

  1. Title and description should be full, with some padding at right
  2. Reduce the gap between the categories shimmer in the last row
  3. Handle for the mobile screen aswell

Reproduction URL

https://wanderlust-beta.vercel.app/

Reproduction steps

1. Navigate to the URL 
2. When posts are initial loaded, we see that the actual content and the card skeleton is not same

Logs

No response

Browsers

No response

OS

No response

krishnaacharyaa avatar Mar 23 '24 17:03 krishnaacharyaa

Hi there! I'm excited to contribute to this project and would love to work on this issue. Could you please assign it to me? Thanks!

thefarhanahmad avatar May 09 '24 18:05 thefarhanahmad

Hii Krishna , hope you are doing good . I want to contribute to the frontend of this project . can you please assign this to me .

SahilSuman1011 avatar May 11 '24 19:05 SahilSuman1011

What is the approach @SahilSuman1011 you are gonna follow and ETA

krishnaacharyaa avatar May 11 '24 19:05 krishnaacharyaa

i am gonna work on the ui part to make it look more bright and catchy .

SahilSuman1011 avatar May 11 '24 19:05 SahilSuman1011

Okay pro tip @SahilSuman1011 If you wanna grow in this open source community... Show that you are actually into the project and actually want to create an impact.... Soo see your comments it is very generally thrown and may be to 10s of project, there is no attention to detail... So the one who wants to assign you , will never assign you because you don't know what you are doing and you just want some points or somehow got the PR merged...

It won't happen... Stick to a project understand it ... Try to contribute thoroughly. You'll be benefited with good amount of points and the PA and mentor also will have a positive feedback...

This no one might tell you, felt like sharing it... Who knows if you follow this ... You may reach somewhere in the leaderboard

All the best 🙂👍🏻

krishnaacharyaa avatar May 11 '24 19:05 krishnaacharyaa

Expected Behavior

  1. Title and description should be full, with some padding at right
  2. Reduce the gap between the categories shimmer in the last row
  3. Handle for the mobile screen aswell

Reproduction URL

@krishnaacharyaa Can you please assign me this issue under GSSoC'24 i would like to work on it.

Chelseasingla1 avatar May 13 '24 08:05 Chelseasingla1

Expected Behavior

  1. Title and description should be full, with some padding at right
  2. Reduce the gap between the categories shimmer in the last row
  3. Handle for the mobile screen aswell

Reproduction URL

@krishnaacharyaa Can you please assign me this issue under GSSoC'24 i would like to work on it.

Thankyou sir for assigning!!

Chelseasingla1 avatar May 13 '24 08:05 Chelseasingla1

Is there an existing issue for this?

  • [x] I have searched the existing issues

Current Behavior

image image

Expected Behavior

  1. Title and description should be full, with some padding at right
  2. Reduce the gap between the categories shimmer in the last row
  3. Handle for the mobile screen aswell

Reproduction URL

https://wanderlust-beta.vercel.app/

Reproduction steps

1. Navigate to the URL 
2. When posts are initial loaded, we see that the actual content and the card skeleton is not same

Logs

No response

Browsers

No response

OS

No response

@krishnaacharyaa There is one issue with description if we want full description it is possible but because of one i am facing issues should i decrease its content? Screenshot 2024-05-13 165713

Otherwise it is okay!!

Chelseasingla1 avatar May 13 '24 11:05 Chelseasingla1

Is there an existing issue for this?

  • [x] I have searched the existing issues

Current Behavior

image image

Expected Behavior

  1. Title and description should be full, with some padding at right
  2. Reduce the gap between the categories shimmer in the last row
  3. Handle for the mobile screen aswell

Reproduction URL

https://wanderlust-beta.vercel.app/

Reproduction steps

1. Navigate to the URL 
2. When posts are initial loaded, we see that the actual content and the card skeleton is not same

Logs

No response

Browsers

No response

OS

No response

@krishnaacharyaa There is one issue with description if we want full description it is possible but because of one i am facing issues should i decrease its content? Screenshot 2024-05-13 165713

Otherwise it is okay!!

Or if not then it would be like this showing a little less description: image

Chelseasingla1 avatar May 13 '24 11:05 Chelseasingla1

@krishnaacharyaa There is one issue with description if we want full description it is possible but because of one i am facing issues should i decrease its content?

But wait @Chelseasingla1 what are you working on? Why is this description soo long? Don't touch anything here.... You just have to mimick the height and width of the shimmers (skeleton here)

krishnaacharyaa avatar May 13 '24 11:05 krishnaacharyaa

https://github.com/krishnaacharyaa/wanderlust/pull/143/files

your code changes, will look like this in its relevant file, may be all-blog-skeleton file @Chelseasingla1 that's it

I didn't understand how this description became big and why it is the concern, in production we don't have such description

krishnaacharyaa avatar May 13 '24 11:05 krishnaacharyaa

https://github.com/krishnaacharyaa/wanderlust/pull/143/files

your code changes, will look like this in its relevant file, may be all-blog-skeleton file @Chelseasingla1 that's it

I didn't understand how this description became big and why it is the concern, in production we don't have such description

@krishnaacharyaa Ohkay i thought you want full description i got it now thankyou i will make changes accordingly now.

Chelseasingla1 avatar May 13 '24 11:05 Chelseasingla1