fluffychat icon indicating copy to clipboard operation
fluffychat copied to clipboard

Font Sizing is not working correctly throughout the messages.

Open bmcgonag opened this issue 2 years ago • 6 comments

Bug Description

The font sizing seems to try and follow the OS font settings in iOS. The issue I see is that some messages (inside the bubble) don't size the font properly. It seems a bit random, so not sure why it's happening.

OS: iOS 16.5.1 (c) Device: iPhone 11 FluffyChat: v 1.12.0

I will add images to show what's happening. In particular notice the variation in font size per message regardless of sender / receiver.

Steps to Reproduce

  1. adjust the standard font size in iOS to something larger than normal. a. Settings b. Accessibility c. Display and Text Sizes d. Large Text = On, and in that screen adjust the font size slider to the left of center. (image attached)
  2. Create a new chat, or join an existing room on FluffyChat.
  3. Look at the variation in message sizes.

Expected Behavior

Given the enlarged font sizes, the messages will all have appropriately larger font sizes, and all messages will be consistent with their font sizing.

App Version

1.12.0

Additional Platform Information

iPhone 11, iOS 16.5.1 (c)

Additional Context

Please let me know if there is anything else I can provide. Logs, other details, testing, etc. And thank you so much for this really great app!

IMG_0417 IMG_0418 IMG_0419

bmcgonag avatar Jul 31 '23 15:07 bmcgonag

I'm seeing this with 1.13 on Android so I think it's a cross platform issue.

seankhl avatar Aug 04 '23 06:08 seankhl

This happens on Linux, Android, and iOS at least

gabrc52 avatar Dec 01 '23 02:12 gabrc52

i'm on android running FluffyChat 1.16.0 and am also experiencing this exact bug

lolbinarycat avatar Dec 24 '23 03:12 lolbinarycat

I am looking into this and have found the source of this bug to be in the flutter_linkify library: https://github.com/Cretezy/flutter_linkify/issues/135

The last time someone brought it up, the developer of the library blamed Flutter: https://github.com/Cretezy/flutter_linkify/issues/22

I will work on a PR to the upstream library.

gabrc52 avatar Mar 26 '24 22:03 gabrc52

This issue is stale because it has been open for 120 days with no activity.

github-actions[bot] avatar Aug 06 '24 01:08 github-actions[bot]

the library this bug is from is unmaintained and needs to be forked in order for this to get fixed

lolbinarycat avatar Aug 06 '24 06:08 lolbinarycat

Are there news for this? This is an instant turnoff (aka. uninstall) for any friend/family member who gave a chance to FluffyChat.

PhilC813 avatar Jan 24 '25 04:01 PhilC813

Still waiting on the library. Who wants to fork it?

gabrc52 avatar Jan 24 '25 12:01 gabrc52

@gabrc52 This is a very tiny library and shouldn't be hard to maintain. I'm happy to fork it (either under my own user or under https://github.com/pariyatti/ which could use linkify for some of our upcoming features. However, I wanted to check first to make sure you folks don't want it to live somewhere more central. Perhaps @krille-chan would want to fork?

Let me know, either way, and I'll go ahead if no one else wants to maintain the fork. Thanks!

deobald avatar Apr 09 '25 17:04 deobald

It would be nice if you @deobald or @krille-chan forks it.

gabrc52 avatar Apr 09 '25 21:04 gabrc52

I will write an email to the original author with the question if I could take over maintainership of the package :)

krille-chan avatar Apr 15 '25 12:04 krille-chan

Nevermind I found another workaround: https://github.com/krille-chan/fluffychat/pull/1763

krille-chan avatar Apr 15 '25 12:04 krille-chan