ED64 icon indicating copy to clipboard operation
ED64 copied to clipboard

Fixed issues with 0xff padding check and removal

Open JasonCampbell256 opened this issue 2 years ago • 1 comments

Description

This PR fixes an issue that prevents ROMs from loading to EverDrive x7 via USB.

Related Issue

(https://github.com/krikzz/ED64/issues/23)

Motivation and Context

Could not load any ROMs, failed on Index out of Range error. Fixing this error revealed that a loop was returning a method when it should have been breaking the loop. After fixing this error most ROMs (padded and unpadded) worked, but Super Mario 64 did not. Added a condition to only check for padding if ROM is below 3 MB in order to hopefully exclude all retail ROMs from breaking.

How Has This Been Tested?

Loaded padded and unpadded roms, both homebrew and retail successfully.

Screenshots (if appropriate):

JasonCampbell256 avatar May 22 '22 04:05 JasonCampbell256

LGTM... Seems I made a stupid error there...

networkfusion avatar May 23 '22 20:05 networkfusion