isomorphic-style-loader
isomorphic-style-loader copied to clipboard
useStyles enhancement
@dazlious hello there! Any progress on this PR?
This isBrowser
check seems to always return undefined
. If you take a look at dist/useStyles
you'll see that this
is transpiled into var _this = undefined
and is never assigned with actual value:
// version 5.3.2
var _this = undefined;
var isBrowser = function () {
// _this is undefined, so isBrowser() always returns undefined
return _this && typeof _this.window === 'object';
}();
https://github.com/kriasoft/isomorphic-style-loader/pull/198/files#diff-78c41e68a949b765a2709713f56f0f5e6542ffe54315f44719e44c413c0fc2e2L16
I would really appreciate if you could merge this PR since it fixes issue described above
@dazlious hello there! Any progress on this PR? This
isBrowser
check seems to always returnundefined
. If you take a look atdist/useStyles
you'll see thatthis
is transpiled intovar _this = undefined
and is never assigned with actual value:// version 5.3.2 var _this = undefined; var isBrowser = function () { // _this is undefined, so isBrowser() always returns undefined return _this && typeof _this.window === 'object'; }();
https://github.com/kriasoft/isomorphic-style-loader/pull/198/files#diff-78c41e68a949b765a2709713f56f0f5e6542ffe54315f44719e44c413c0fc2e2L16
I would really appreciate if you could merge this PR since it fixes issue described above
Still waiting for a reply here: https://github.com/kriasoft/isomorphic-style-loader/pull/198#discussion_r786649814