isomorphic-style-loader icon indicating copy to clipboard operation
isomorphic-style-loader copied to clipboard

Possibility to specify type attribute

Open BilyachenkoOY opened this issue 5 years ago • 6 comments

Now it will be possible to specify type attribute of

BilyachenkoOY avatar Jun 25 '19 08:06 BilyachenkoOY

Codecov Report

Merging #163 into master will increase coverage by 0.29%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   80.95%   81.25%   +0.29%     
==========================================
  Files           4        4              
  Lines          63       64       +1     
  Branches       15       17       +2     
==========================================
+ Hits           51       52       +1     
  Misses         11       11              
  Partials        1        1
Impacted Files Coverage Δ
src/insertCss.js 75.6% <100%> (+0.6%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a990d94...4c2e321. Read the comment docs.

codecov-io avatar Jun 25 '19 08:06 codecov-io

Why not just remove this line at all? https://github.com/kriasoft/isomorphic-style-loader/blob/a990d947e79b47251f1af827adc81918494413fd/src/insertCss.js#L69

frenzzy avatar Jun 26 '19 14:06 frenzzy

For backward compatibility at least

BilyachenkoOY avatar Jun 26 '19 15:06 BilyachenkoOY

@frenzzy Any news on this PR?

BilyachenkoOY avatar Aug 09 '19 09:08 BilyachenkoOY

@BilyachenkoOY sorry, I am not interested in maintenance isomorphic-style-loader anymore since I switched to using Emotion.

frenzzy avatar Aug 09 '19 10:08 frenzzy

@koistya can you help with this? :)

BilyachenkoOY avatar Aug 09 '19 10:08 BilyachenkoOY