babel-starter-kit icon indicating copy to clipboard operation
babel-starter-kit copied to clipboard

Published 20 hours ago • verified publisher icon kriasoft

Converted build script to es2015

Open axis-tip opened this issue 8 years ago • 3 comments

This starter kit is a fantastic resource... thank you!

One thing that threw us off as we were learning es2015 and all the new patterns with babel, was that not all the javascript in this starter kit is consistently next gen javascript. The build script was still using promises.

So for our own purposes (and for learning) we rewrote this build script to use async/await and import vs require.

No worries if you guys don't want to merge this... but thought you might want to take a look at it so others who review this project can see all consistent javascript.

axis-tip avatar Sep 12 '16 21:09 axis-tip

Coverage Status

Coverage remained the same at 100.0% when pulling 6c3fea9c548988b772e497cee15ac962669b7317 on axis-tip:babel-build into 4c7745cf1f86c95d9fb8a5247232a8940725108f on kriasoft:master.

coveralls avatar Sep 12 '16 21:09 coveralls

@axis-tip good PR, thanks! The reason why the build script doesn't use async/await is because running it via native node executable is much faster than babel-node. But Node.js v7 should be released soon (perhaps in October or November) and I will merge this PR right after that.

koistya avatar Sep 13 '16 06:09 koistya

With node 8, it's time :-) But this code is quite outdated, so best will be create entire new PR.

langpavel avatar Jul 22 '17 03:07 langpavel