terraform-provider-docker
terraform-provider-docker copied to clipboard
kreuzwerker
feat: support setting cpu shares
Hi @Blackskyliner , thank you for such a great work!
I'm wondering how can I use your fork before it's merged?
@jizusun
As far as I know you will have to follow this: https://developer.hashicorp.com/terraform/language/providers/requirements#in-house-providers
So register it with either a private registry or under your own namespace in the official registry.
EDIT: Or host it as local_mirror or even network_mirror which may be a bit more involved: https://developer.hashicorp.com/terraform/cli/config/config-file#provider-installation
I don't get why this is not moving anywhere. No initial review done in almost a year now.
There is need for this by some, it makes sense to integrate it as it was done for gpus.
So is this whole repository/plugin deprecated not maintained anymore?
I can also see that its not top-priority to look into this repository until they need it for their business but it would be great if at least on an occasional basis one of the authorized people could look into some PRs. Otherwise the PR feature could just be disabled to indicate that nothing can be contributed because of never-reviewed-because-of-time-or-incentive-constraints, as contributors also take their time to provide the patch as PR which may also lead to double implementations as seen here where now both implementations will need to be compared as which to integrate if a review gets to get going, increasing the workload for the reviewer.
We are moving forward to fix the pipeline in the newest PR. If this is done, we will work on all the PRs. Unfortunately it will take a short while to get up to speed in the project. Your support would be apprechiated. #613
Rebased onto current master w/o problems and/or any conflicts.
Do I need to add a test for the changes or do we assume that the config parsing and used library is well-tested enough.
I don't know how feasible this is, but a really useful addition would be the ability to specify the CPU number in percent. That way if deployed to a different kind of host with more / less CPUs, it would adjust the amount of CPU allocated.
Hello, I was looking for cpus limit solution and I came across on this PR. What is the current state of the PR?
@enc I can upgrade my PR to latest master but would only do that if it would get merged in a timely manner.