terraform-provider-docker
terraform-provider-docker copied to clipboard
feat: Add triggers attribute to docker_registry_image
Scope
- Add triggers Map attribute to docker_registry_image
- This can be used to rebuild an image when contents of source code folders change or to repush a local image
This is inspired from #425, despite the fact that it was mentioned that the build capabilities from docker_registry_image will be all migrated to docker_image, that would solve the build issue, but triggers can also be used to force a repush.
@Junkern Would be really cool to have this merged. Can I help with anything here? Does the change is simple as that?
Agreed that this should probably go in or the semantics of docker_registry_image become available as docker_image (to wit, docker_registry_image is still useful on its own because you can segregate your image builds into a different provider).
Sorry for the long delay. You are all right, even though we want to migrate the build capabilities from docker_registry_image over to docker_image it might still be helpful to have the triggers attribute.
@WassimKallel do you mind rebasing this PR so that we can merged this and release a new version?
Sorry for the long delay. You are all right, even though we want to migrate the build capabilities from
docker_registry_imageover todocker_imageit might still be helpful to have thetriggersattribute.@WassimKallel do you mind rebasing this PR so that we can merged this and release a new version?
I've pulled down @WassimKallel branch, rebased it on master and then opened #496 . Looks like it preserved the authorship.
#496 is merged and will be published latest tomorrow. Closing this.