terraform-provider-docker icon indicating copy to clipboard operation
terraform-provider-docker copied to clipboard

chore(build): clean makefile and build workflows

Open mavogel opened this issue 3 years ago • 1 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The targets in the Makefiles are outdated, remove and/or adapt them

  • [ ] fmtcheck and fmt : use a pre-commit-hook
  • [x] vet, errcheck: is part of golangci-lint

Make the workflows DRY and optimize

  • [ ] add a cache for make setup. (Do we need this? make setup is quite fast and not the bottleneck in CI runs)
  • [ ] add a name for each step
  • [ ] unify the website jobs
  • [x] use only major.minor versions for terraform, for not having to update the patch versions

Optimize Worflows

  • [x] there is no need to run compile on tags and when a _test.go file has changed
  • [ ] unify website yamls

New or Affected Resource(s)

  • docker_*

References

  • #94

mavogel avatar May 20 '21 08:05 mavogel

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. If you don't want this issue to be closed, please set the label pinned.

github-actions[bot] avatar Jul 25 '21 10:07 github-actions[bot]