terraform-provider-docker icon indicating copy to clipboard operation
terraform-provider-docker copied to clipboard

fix: parse file_mode as 8 based value

Open suzuki-shunsuke opened this issue 4 years ago • 7 comments
trafficstars

Close #66

suzuki-shunsuke avatar Mar 30 '21 03:03 suzuki-shunsuke

Hmm... DiffSuppressFunc doesn't work as expected. I'll investigate.

suzuki-shunsuke avatar Mar 30 '21 03:03 suzuki-shunsuke

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. If you don't want this pull request to be closed, please set the label pinned.

github-actions[bot] avatar May 29 '21 10:05 github-actions[bot]

Per my comment in #66 this is still not working

tomalok avatar May 29 '21 19:05 tomalok

@suzuki-shunsuke how about we skip the suppress function and make it a Breaking Change for v3.0.0? Would you be fine with this?

mavogel avatar Jun 21 '21 15:06 mavogel

I'll fix the conflict.

how about we skip the suppress function and make it a Breaking Change for v3.0.0? Would you be fine with this?

I'll consider.

suzuki-shunsuke avatar Jun 22 '21 13:06 suzuki-shunsuke

Ok I'll remove it from the next milestone and we will put it accordingly to the changes to another v2.x or then to v3.x

mavogel avatar Jun 22 '21 15:06 mavogel

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. If you don't want this pull request to be closed, please set the label pinned.

github-actions[bot] avatar Aug 22 '21 10:08 github-actions[bot]