krausest
copy/paste selection doesn't appear to work
Copy/paste selection is confusing. Doesn't appear to help me store my selections for use in the future. I'm on the chrome 124 browser on a Chromebook. Same issue for current.html and today's release of Chrome 124 data. Best wishes!
Sorry, I have no chromebook to check. Is it possible to open a console on a chromebook and see if there's some output?
Hi, Steps from current.html:
- change the list of frameworks
- click the X
- click copy button
- Url changes to this
- I bookmark this link and open in another tab. Then click the button and see this error in dev console:
index-gG23Mmdu.js:324 Pasting state failed SyntaxError: Unexpected token 'h', "https://kr"... is not valid JSON
at JSON.parse (
) at index-gG23Mmdu.js:324:428 at index-gG23Mmdu.js:324:780
I'm closing this issue. I'm not able to reproduce this (but I also have no chrome book to verify).
Any chance you tried it on Chrome? Shane Whittet
On Sat, Dec 14, 2024, 1:31 PM Stefan Krause @.***> wrote:
Closed #1672 https://github.com/krausest/js-framework-benchmark/issues/1672 as completed.
— Reply to this email directly, view it on GitHub https://github.com/krausest/js-framework-benchmark/issues/1672#event-15658368786, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUV2AH4QO7HYE7DPCBKZ32FSBQXAVCNFSM6AAAAABTTZRKJ2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGY2TQMZWHA3TQNQ . You are receiving this because you authored the thread.Message ID: @.*** .com>
Where my listed steps the correct steps?
Shane Whittet
On Sat, Dec 14, 2024, 3:07 PM Stefan Krause @.***> wrote:
Yes, I tried it with chrome 131 on OSX.
— Reply to this email directly, view it on GitHub https://github.com/krausest/js-framework-benchmark/issues/1672#issuecomment-2543344810, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUV2F7VKGTK6F3DF7P26D2FSMZLAVCNFSM6AAAAABTTZRKJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTGM2DIOBRGA . You are receiving this because you authored the thread.Message ID: @.***>
Were my steps correct? Shane Whittet
On Sat, Dec 14, 2024, 3:09 PM Shane Whittet @.***> wrote:
Where my listed steps the correct steps?
Shane Whittet
On Sat, Dec 14, 2024, 3:07 PM Stefan Krause @.***> wrote:
Yes, I tried it with chrome 131 on OSX.
— Reply to this email directly, view it on GitHub https://github.com/krausest/js-framework-benchmark/issues/1672#issuecomment-2543344810, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEUV2F7VKGTK6F3DF7P26D2FSMZLAVCNFSM6AAAAABTTZRKJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTGM2DIOBRGA . You are receiving this because you authored the thread.Message ID: @.***>
I tried what you described, but it works on OSX. However I'm trying to store the state in the URL and the URL has some platform specific limited length. So I can imagine that there's an issue.
Using the URL isn't a real use case for me. When I update some frameworks I have locally the new results and on github the last published results. To make a comparison I'm selecting the frameworks on the local results, then press the copy button to get the state in the clipboard. On the github page I'm using the paste button to get the same frameworks selected from the clipboard. This shouldn't run into any length issues.
I also confirm that this functionality is broken, maybe not completely but in most of cases when copy/pasting that URL string it just doesn't work (I am on Ubuntu btw). I didn't dug into that and honestly I don't want to as it feels weird even when it works, the localStorage would bring a much better experience than copy/pasting that URL string.
What's your use case for doing so? I'm always coping and pasting the selection on different domains (localhost and github) such that localStorage wouldn't help me. I could store the selection in localStorage if that helps anyone...
I already noticed from your previous comment that "our" issue is not actually an issue for you, but more like a feature tailored for your specific use case. Since we (users) generally do not analyze benchmarks between different domains, the main use case is to have the selected configuration persistent between public benchmarks releases OR between local benchmark tests. So for majority there is no need to have this copy/paste feature working for both domains in the same time.