krateng
make `auth.getMobileSession` return XML
#292
XML will now return from auth.getMobileSession, but not scrobbling yet.
The Last.FM API actually has options to return both JSON and XML, but I believe XML is supposed to be returned by default. Feel free to either close or merge this PR.
Do you have a scrobbler that fails because of this? I'm a bit anxious about changing behaviour that someone's workflow might rely on.
Do you have a scrobbler that fails because of this? I'm a bit anxious about changing behaviour that someone's workflow might rely on.
@krateng Yes actually, this came up because I was helping reconfigure the game Audiosurf 2 (not Audiosurf 1 which I already implemented maloja scrobbling for) and since the way to do that is to redirect Last.FM Audioscrobbler 2.0 queries to maloja, it actually fails when JSON is returned as I found out by checking it with Fiddler.
Alright, could you add a little check so that we still return the old json when the argument asks for it?
This last commit should do that. I'm not sure of any projects that require json to test with, but I do know Audiosurf 2 works with this.
Is there anything else needed to get this PR merged? I'm using the XML feature a lot and I've been stuck on my own fork for the feature. Shall I also convert submit_scrobble for consistency or would you rather I stick to only changing authmobile to change less stuff?