maloja icon indicating copy to clipboard operation
maloja copied to clipboard

Track more additional information

Open badlandspray opened this issue 3 years ago • 1 comments

Track duration as per the API spec. Store spotify_id in extra Added track_mbid which was requested in #149 Sorry for the minimal PR changes.

badlandspray avatar Jun 09 '22 17:06 badlandspray

@krateng https://github.com/krateng/maloja/blob/a1b2261fa7b497a31d47026a867288f72b988438/maloja/apis/audioscrobbler_legacy.py#L96 Should this be used as duration if duration is not present?

badlandspray avatar Jul 15 '22 15:07 badlandspray

From the API docs, it looks like duration is the total length of the track, is that correct? It should be track_length then.

Is there any reason you need the other fields? track_mbid is a good idea, but I think all the mbids already define the track fully and I'm not sure we want to store proprietary details like Spotify's ID.

krateng avatar Aug 20 '22 15:08 krateng

Yes, duration is the total length of the track in seconds.

The extension I use sends the above information in the payload as per the listenbrainz API and seeing this as a replacement for the listenbrainz API, I thought it'd make sense to have these fields.

badlandspray avatar Sep 11 '22 17:09 badlandspray

The API is of course meant to be compatible, so it should accept those fields, but Maloja itself doesn't need to store all information that Listenbrainz stores.

krateng avatar Sep 11 '22 18:09 krateng