Krasimir Georgiev
Krasimir Georgiev
Thank you! Chatted with @buchgr this looks good to merge, with a follow-up issue https://github.com/bazelbuild/rules_rust/issues/2548 about the potential user confusion around user-defined --deny flags.
Could you provide a minimal example where this reproduces and/or add a regression test for this? How does the linking fail exactly? It feels like this PR will disable coverage...
Thank you! This is super exciting and I'm looking to review it but will need some time to read up on the details of panicking. Want to pay special attention...
>When I try to enable experimental_use_cc_common_link for rust_library... What is the underlying issue that triggered your experiments? It's not the case that "experimental_use_cc_common_link" is not supported for rust_library-es; rather this...
> Long: https://bazelbuild.slack.com/archives/CSV56UT0F/p1709026282260219 > > In Short: Running `bazel run @rules_rust//tools/rust_analyzer:gen_rust_project` does not work when the system compiler does not support -lgcc_s, which automatically gets added by rustc. The error...
>The bug only does not get triggered, because when experimental_use_cc_common_link is True, output_hash always is None. > >I argue that this is pure conincidence and this precondition should either be...