Krasimir Georgiev
Krasimir Georgiev
The nondeterminacy is surprising, especially on linux. Having the path prefix seems reasonable, but I'd like to understand better the source of the nondeterminacy, e.g., is it coming from rustc...
> cargo_build_script
(sorry accidentally closed the pr when trying to post a comment) I think this PR makes sense for the reasons @scentini points out -- they are just too different than...
Chatted a bit with @scentini: * the `BuildInfo` feels like part of core rules_rust; it's important at least for integration with third party dependencies / the crate universe / etc...
>Passing --extra_rustc_flags to CARGO_ENCODED_RUSTFLAGS certainly seems reasonable to me from [the description](https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts). +1 About `--extra_exec_rustc_flags`: I played a bit and I believe the `--extra_exec_rustc_flags` are propagated to the `script [cfg...
> I'm happy to merge main to update this if the maintainers want to merge it, let me know. I definitely understand not wanting to maintain these hacks though. This...
Right, it's private. However there are already folks using it despite that (not saying that's good or bad, just it exists): https://github.com/google/crubit/blob/6ff59f1d0c784440dc13ea0597c1567d95e69884/rs_bindings_from_cc/bazel_support/rust_bindings_from_cc_utils.bzl#L140 Currently the crubit maintainers absorb the maintenance bunder...
> Will / should this have any impact on if you're linking `rust_library` targets into `cc_binary` targets instead of top level `rust_*` targets as you mention here? I think the...
>looks like cargo:rustc-link-lib (etc) directives emitted from a cargo_build_script get dropped Ah, nice catch! Something to fix definitely. @bsilver8192 I feel your comment on this issue is sufficient to capture...
The remap path prefix is not user-configurable I believe. We have it as a param to the internal function that computes the compiler flags, but that's only ever called with...