EditorGroups icon indicating copy to clipboard operation
EditorGroups copied to clipboard

Open Issues

Open krasa opened this issue 7 years ago • 19 comments

Missing Features:

  • [x] indexing
  • [ ] toolwindow
  • [x] switching between groups for a single file
  • [ ] update caches on file system changes
  • [ ] language support
    • [ ] grammar + PSI / YAML?
    • [ ] refactoring support
    • [ ] remove from group, add to group actions

Broken things:

  • [x] panel scrollling
  • [x] using it in multiple editor windows (floating, splitted)
  • [x] tab title needs to get updated after switching groups
  • [x] nicer tab reusing - for some reason some specific files move the tab
  • [x] EditorTabTitleProvider has bad design, two identical files in two windows, in two groups rewrite each others title - https://youtrack.jetbrains.com/issue/IDEA-192305
  • [x] cache concurrency

Nice to have:

  • [x] get JetBrains to fix the flickering when switching files - the panel is created too late
  • [x] pattern support for @idea.related including Project and Module macro
  • [x] include all when extension is not defined
  • [x] include by name from the whole project
  • [x] custom rendering for file buttons
  • [x] autogroup by current folder
  • [x] autogroup by current filename
  • [x] integrate Favourites groups
  • [x] unique button file names

krasa avatar May 16 '18 22:05 krasa

Hey, really cool effort! I'll save off reporting any bugs for a little bit as I guess you are probably well aware of most of them.

I am using it right now though and it is already making my life easier.

SomewhatCloudy avatar May 17 '18 09:05 SomewhatCloudy

Well, I now fixed all I knew about and is not on the list. So if you have anything to add...

krasa avatar May 17 '18 13:05 krasa

The number in the top appears stuck in the latest build - I have 3 in a group but it's still 2. It would be nice if it refreshed automatically on file save too. - apart from that I am having trouble coming up with things to complain about but I'll do my best! ;)

SomewhatCloudy avatar May 18 '18 08:05 SomewhatCloudy

Yeah, the number was off by 1 :) The file is indexed automatically by IntelliJ pretty often - I hooked there updating of the panel and the title, I hope it won't lag

I know it's hard, this plugin is just too perfect :)

krasa avatar May 18 '18 17:05 krasa

I can't get any version to compile past 0.4:

editor-groups/src/krasa/editorGroups/EditorGroupTabTitleProvider.java
Error:(52, 9) java: method does not override or implement a method from a supertype

It may just be me being dumb, not a Java expert here!

Also you may want to .gitignore the .idea directory as it's fighting with my config.

SomewhatCloudy avatar May 22 '18 11:05 SomewhatCloudy

Just comment that method, it is from a hopefully future api.

Done

krasa avatar May 22 '18 13:05 krasa

I would almost release it, but the scrollbar is hopelessly broken https://gfycat.com/FelinePleasingGadwall

krasa avatar May 22 '18 13:05 krasa

I'm also getting an error in PHPStorm: org/apache/commons/lang3/builder/ToStringBuilder

Not sure what version it started in though.

SomewhatCloudy avatar May 22 '18 14:05 SomewhatCloudy

fixed.

krasa avatar May 22 '18 14:05 krasa

Cool, that worked!

I'll have a proper think about it and give you some feedback soon, hopefully! I guess there is nothing that can be done about the juddering?

SomewhatCloudy avatar May 22 '18 14:05 SomewhatCloudy

I have asked on the forum, but it will most probably need a change in the platform. Or maybe it would be better to have a vertical bar on the right.

krasa avatar May 22 '18 18:05 krasa

I suspect a vertical bar would look like crap. It's not possible to pre-draw then to speed up render? If not drawing a grey box first (and adding the contents later) might look better (again if possible).

Some issues I have come across: If you have two files with the same filename (in my case a route and a controller) there is no differentiation. Perhaps the path segments that are unique may help, so... 'controllers/mine.js' and 'routes/mine.js'

I also like the 'switch editor groups' button, but think it would be better if, when selecting a new group, it opened alongside the current group rather than replacing it - or add a ctrl+click for opening in a new tab.

Adding a @idea.title to a file that is already in a group also makes it behave strangely. I suppose that is to be expected though.

SomewhatCloudy avatar May 23 '18 13:05 SomewhatCloudy

I just made it as fast as possible, the panel is created under 1ms, but it still flickers, because it is executed asynchronously.

Agree on those 2 other things.

@idea.title creates a new group...

krasa avatar May 23 '18 14:05 krasa

Good news: it will not flicker in 2018.2

krasa avatar Jun 01 '18 14:06 krasa

Cool! I'll try that out.

SomewhatCloudy avatar Jun 03 '18 09:06 SomewhatCloudy

I cannot install the plugin in WebStorm 2018.1.4. I get:

Plugin 'Editor Groups' is incompatible with this installation.

I'm running: WebStorm 2018.1.4 Build #WS-181.5087.27, built on May 21, 2018 JRE: 1.8.0_152-release-1136-b39 amd64 JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o Windows 8.1 6.3

codessentials avatar Jul 03 '18 08:07 codessentials

Congrats on the release! Look forwards to giving the final version a try.

SomewhatCloudy avatar Jul 03 '18 08:07 SomewhatCloudy

I have made it compatible with 2018.1, not sure how well it will work. Now it is pending JetBrains approval.

Or you can install it from here https://github.com/krasa/EditorGroups/releases

krasa avatar Jul 03 '18 09:07 krasa

Just installed latest (.20) on PhpStorm 2018.1.6 on OSX High Sierra and everything works fine! it of an upgrade from 0.4, nothing really to complain about!

SomewhatCloudy avatar Jul 11 '18 13:07 SomewhatCloudy