pcov icon indicating copy to clipboard operation
pcov copied to clipboard

Fix php_pcre_match_impl with 8.4

Open remicollet opened this issue 1 year ago • 5 comments

remicollet avatar Jul 12 '24 08:07 remicollet

works good, let's get it in

andypost avatar Jul 12 '24 15:07 andypost

Works on Windows (MSVC), too.

cmb69 avatar Aug 07 '24 16:08 cmb69

Hey @remicollet thanks for the PR for PHP 8.4 support.

Do you have a timeline for merging / releasing this PR? Will you wait until PHP 8.4 RC1 or GA?

Jubeki avatar Sep 13 '24 13:09 Jubeki

Do you have a timeline for merging / releasing this PR? Will you wait until PHP 8.4 RC1 or GA?

I always consider it strange to release a new version, stating "Compatible with 8.4" during alpha/beta, which does not have the Final API. So yes, I think it is better to wait for RC1.

BTW, the decision is to the owner, so to @krakjoe

remicollet avatar Sep 13 '24 13:09 remicollet

API bump/fix will happen in 2 weeks with RC1, this is only fix required to work on 8.4 so better to wait final polishing

andypost avatar Sep 13 '24 13:09 andypost

RC1 is out and API finally fixed, used to rebuild with this patch and no issues detected

andypost avatar Sep 29 '24 08:09 andypost

Joe Watkins aka @krakjoe, needs help.

I encourage you to check out the GoFundMe campaign https://gofund.me/8b6df24f.

Additionally, sharing the story within your networks can help raise awareness and support.

Thank you for taking the time to read this and for any support you can provide!

ghostwriter avatar Sep 30 '24 22:09 ghostwriter

Is there any update on when this PR is going to get merged?

ariaieboy avatar Nov 25 '24 18:11 ariaieboy