Joe Watkins

Results 70 comments of Joe Watkins

I dislike suppressing warnings, I'll have a look and see if they can't be fixed next time I boot a windows vm.

Please provide reproducing code.

This is possible without any additional upstream change, we could do this.

I'm not sure if this is reasonable ... let me think ...

It just doesn't really make sense for me to support that. However, you may apply https://github.com/krakjoe/tombs/commit/d81fa372911e03659a44f8121723a421d17938cf to the current source code as a patch and compile against 5.3/4 I have...

Did you end up running any tests ?

Thanks very much :) On Mon, 19 Apr 2021 at 12:18, Marc FRICOU ***@***.***> wrote: > Not yet, it's been delayed. Be sure l'll share feedback > > — >...

should follow php-src coding standards

This is confusing, please clarify what you mean @marc-mabe ?

I done some stabbing, any good ?