apcu icon indicating copy to clipboard operation
apcu copied to clipboard

Does APCu support still support the max_file_size configuration setting?

Open holtkamp opened this issue 7 years ago • 4 comments
trafficstars

It seems that APCu does not support the max_file_size configuration setting anymore. Is this correct?

  • APC: http://php.net/manual/en/apc.configuration.php#ini.apc.max-file-size
    • https://github.com/php/pecl-caching-apc/blob/6a904063fe753299e8c7c5b2c6658b1976a61de2/apc_main.c#L680-L683
  • APCu: http://php.net/manual/en/apc.configuration.php

The CHANGELOG only mentions it being added, but does not seems to be used any more.

On the https://github.com/krakjoe/apcu/releases page, I can not find anything about it.

In case support for max_file_size is dropped in APCu, is there some documentation about this? Curious about the "why", since it seems a useful feature 🤓

holtkamp avatar Jul 16 '18 09:07 holtkamp

APCu does not cache files anymore (this is opcache's job), so what would a max_file_size option even do?

nikic avatar Jul 16 '18 10:07 nikic

@nikic aah, ok, file, doh!

I guess I was looking for a max_entry_size to skip any cache entries exceeding that limit. Probably I need some coffee first 😉

Is / was such feature like max_entry_size ever considered?

holtkamp avatar Jul 16 '18 10:07 holtkamp

I think in principle the feature makes sense. This is blocked on #305 though, which will allow us to know the size of the cache entry without allocating SHM memory for it.

nikic avatar Jul 16 '18 17:07 nikic

ok, thanks for the response. Then I will keep this issue open, ok?

holtkamp avatar Jul 17 '18 07:07 holtkamp