zoid
zoid copied to clipboard
fix: properly handle render errors in 'react' driver.
With this change, a react component that throws on the render()
async method, will check first if the component is still mounted, and in that case attempt to rethrow the error inside the React render loop.
Fixes https://github.com/krakenjs/zoid/issues/334
This looks great to me, thanks for taking this up! Can you add a couple of tests to verify the new behavior?
This looks great to me, thanks for taking this up! Can you add a couple of tests to verify the new behavior?
Thanks! I'll try to work on that when I get some free time. Since I'm on Windows I've been having a really though time making the project work with all the npm scripts intended for UNIX environments :(
Totally, sorry about the poor Windows support. If there are any changes you would like to include to improve cross-compatibility there, I'd be happy to merge them in.
When will this be released? Seems like a major issue that is not being taken seriously with the priority it should have.
will this ever be merged? @tmilar @bluepnume