zoid
zoid copied to clipboard
krakenjs
Disable error throw
Can you remove any changes to dist, yarn.lock, etc. and just include code changes?
Also, can you please make this guarded by a global, like if (__ZOID__.ALLOW_PARENT_CHILD_VERSION_MISMATCH)
I'm thinking we should still validate the major version no matter what. This may require some additional thought...
The problem I want to avoid here is compatibility issues between parent and child, without a clear error message. This is a really easy situation to end up in if zoid adds a new parameter to the interface between parent and child...
The problem in reality is that parent site and children site may be deployed separately and might be cached, also some changes are really minor that owner is fully aware of what happening, however the error is a blocker
On Tue, Sep 3, 2019 at 01:20 Daniel Brain [email protected] wrote:
I'm thinking we should still validate the major version no matter what. This may require some additional thought...
The problem I want to avoid here is compatibility issues between parent and child, without a clear error message. This is a really easy situation to end up in if zoid adds a new parameter to the interface between parent and child...
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/krakenjs/zoid/pull/226?email_source=notifications&email_token=ABF6UMECCZFHS37EGEFVXP3QHVDPDA5CNFSM4HEIKIDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5WJHJI#issuecomment-527209381, or mute the thread https://github.com/notifications/unsubscribe-auth/ABF6UMCC2Q5IQAWSP5XI7R3QHVDPDANCNFSM4HEIKIDA .
-- Thangnt