kraken-example-with-passport icon indicating copy to clipboard operation
kraken-example-with-passport copied to clipboard

Published 20 hours ago • verified publisher icon krakenjs

requirejs?

Open dennishall1 opened this issue 9 years ago • 2 comments

I noticed requirejs is a dependency, but I don't see where it is used. Perhaps there was a thought of using it, but it didn't materialize? (npm uninstall requirejs .. site runs fine without it, so do builds.)

dennishall1 avatar Feb 15 '16 16:02 dennishall1

Nice catch. requirejs was used in older versions, but perhaps incompletely removed. Tidying up patches are welcome!

aredridel avatar Feb 15 '16 16:02 aredridel

Agree with you both. @dennishall1 if you have time to PR the removal of requirejs that'd be awesome. I'm moving through the various examples and ticking off higher priority items. Eventually I'd get to this one but would be happy to have the help if you're able.

grawk avatar Feb 16 '16 18:02 grawk