cross-domain-utils icon indicating copy to clipboard operation
cross-domain-utils copied to clipboard

Published 20 hours ago • verified publisher icon krakenjs

Write unit tests for untested utilities

Open mstuart opened this issue 4 years ago • 3 comments

There are a lot of useful functions in cross-domain-utils, but they aren't all tested! Write some unit tests for untested utilities.

To find what's missing, run npm test, then open coverage/index.html to see what files are missing tests.

mstuart avatar Oct 02 '20 22:10 mstuart

Hey, I'm trying to get some JS testing experince and this looks like a good opportunity. Please assign me this task and I'll take a look at what useful tests I can add.

Abdul-Sen avatar Oct 02 '20 22:10 Abdul-Sen

Let's keep this issue open? There are many utilities in cross-domain-utils which would benefit from unit tests, if any others are looking for a good PR idea for hacktoberfest.

bluepnume avatar Oct 05 '20 16:10 bluepnume

A lot of functions are left untested because they call other (tested) functions internally. It would be quite easy to add more tests if Sinon is added as a dependency.

pushpinder107 avatar Oct 08 '20 08:10 pushpinder107