meta-clang icon indicating copy to clipboard operation
meta-clang copied to clipboard

clang: Build float128 soft float builtins for x86_64

Open quaresmajose opened this issue 2 years ago • 3 comments

Signed-off-by: Jose Quaresma [email protected]


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

quaresmajose avatar Jul 27 '22 14:07 quaresmajose

One side effect of this patch is that it breaks the mpfr build with clang https://github.com/foundriesio/meta-lmp/commit/8154f36a67c9c9357d0ebc093c31f6efd362b0b6

quaresmajose avatar Jul 27 '22 15:07 quaresmajose

@quaresmajose thanks for the patch, I see that https://reviews.llvm.org/D53608 still has some changes planned, so its not yet final, so we should wait for taking this patch into release. It might need to address the feedback and go through some more review cycles.

kraj avatar Aug 07 '22 06:08 kraj

Thanks for the review, I will keep an eye on it and maybe can try to address the feedback.

quaresmajose avatar Aug 09 '22 09:08 quaresmajose

there is no nativity upstream on https://reviews.llvm.org/D53608 and so close this.

quaresmajose avatar May 02 '23 09:05 quaresmajose