Brandon Kraft

Results 69 comments of Brandon Kraft

I can duplicate that some of my PT bookmarklets appear not to work now, while others still do. I'll take a look.

@datdudejibril This issue will have updates when there has been progress.

Possible cases of error: * Direct method - typo'd URL * Either method - Private URL (private site, HTTP Auth, etc). * Either method - other server error (curl responds...

To confirm, do you mean when you paste into the Editor or into the URL window to scan a site? For the later, that makes sense to happen because the...

In case the line needs to remain, suggesting this upstream to be more surgical: https://github.com/radishconcepts/WordPress-GitHub-Plugin-Updater/pull/79

That's a dilly of a pickle. I would venture that this is something that's ripe for a filter--it already has the built-in priority system. With both issues, it requires buy-in...

My pull from a few months ago (#5) took care of the new theme. Code is probably shitty, though it works.

Now appears to fatal with an uncaught type error (PHP8+) instead of just generating a warning: Should be reproducible via the simple-payment shortcode if the product has an invalid spay_price...

Over time, the issue has moved to `_inc/lib/class-jetpack-currencies.php`'s `format_price` function. While saving a float is good, it probably should also normalize the price in this function so any stored improper...