Kræn Hansen

Results 258 comments of Kræn Hansen
trafficstars

> Is my issue related to that issue you mentioned? Not directly, but I wanted to share my progress trying to run our library with `RCT_NEW_ARCH_ENABLED=1` and React Native 0.74.0...

I think we do have an issue, but I was unable to test it using our integration tests because we use React Native Test App which has an issue https://github.com/microsoft/react-native-test-app/issues/2015....

We don't support bridgeless on iOS and I've created https://github.com/realm/realm-js/issues/6653 to track this 👍

I've rebased on latest `main` to get b88a065cbd50cf1b84f381d1ab1a781d72bd4f2e and force-pushed to your branch 🤞

Latest React Native specific failure: ``` ReferenceError: Property 'btoa' doesn't exist at webByteUtils.toBase64 (/Users/runner/work/realm-js/realm-js/node_modules/bson/lib/bson.cjs:387:15) at Binary#toExtendedJSON (/Users/runner/work/realm-js/realm-js/node_modules/bson/lib/bson.cjs:549:47) at serializeDocument (/Users/runner/work/realm-js/realm-js/node_modules/bson/lib/bson.cjs:4088:36) at serializeValue (/Users/runner/work/realm-js/realm-js/node_modules/bson/lib/bson.cjs:4021:32) at stringify (/Users/runner/work/realm-js/realm-js/node_modules/bson/lib/bson.cjs:4120:30) ``` Metro seems to...

This *might* have been the cause: https://github.com/realm/realm-core/issues/7434 🤞

I've created https://github.com/realm/realm-core/issues/7604 with more information on the root cause of this crash.

Regarding the uncorrect exit code when the subprocess spawed by `nyc` crashes, I've found these issues and PR that I believe is related: - https://github.com/istanbuljs/nyc/issues/798 - https://github.com/istanbuljs/nyc/issues/1535 - https://github.com/istanbuljs/nyc/pull/1546

I agree a valid approach would be for Realm to keep a weak cache of `BSON.ObjectId` and `BSON.UUID` that it has ever returned. We've thought about using a similar approach...

It seems to me we need to add a cleanup of connection state listeners, the same way we clean up other listeners passed to core, as part of the cleanup...