react-mdc-web icon indicating copy to clipboard operation
react-mdc-web copied to clipboard

Ability to style Dialog instances using inline styles

Open ivmarkov opened this issue 7 years ago • 1 comments

Looking at code https://github.com/kradio3/react-mdc-web/blob/master/src/Dialog/Dialog.js line 63, "... otherProps" seem to be placed on the <aside> element.

Is this really useful? What other properties would the user want to put on the aside element?

If we would like to e.g. style the Dialog with min-width/min-height, we currently cannot do this as these do not have the desired effect when put on the <aside> element. Shouldn't you assign "...otherProps" on the <div> element starting on line 65 instead?

ivmarkov avatar Nov 22 '17 15:11 ivmarkov

You right, thank you!

kradio3 avatar Nov 23 '17 11:11 kradio3