cleanCppProject icon indicating copy to clipboard operation
cleanCppProject copied to clipboard

add usage of run-cmake action for CI

Open lukka opened this issue 5 years ago • 2 comments

Hello, here there is a modified version of the CI build, in detail:

  • the workflow execute build and test for the major platforms: linux, macos, windows;
  • the workflow only builds and test, it does not package nor install on the build server; on CI it should not be needed to package and install the package (especially if the package is not automatically tested anyway). Also this make the CI shorter in time; it would make sense to package the product in build on push on master branch though.
  • the workflow uses a specific run-cmake action to configure and build in one step; the run-cmake action provision automatically 'ninja' if not present and it integrates with vcpkg (if used) using the run-vcpkg action;

There might be several reasons that would block this PR or that request heavy changes: I am fine with this of course!

lukka avatar Jan 19 '20 04:01 lukka

@kracejic any input on this PR?

lukka avatar Feb 04 '20 21:02 lukka

Hi, sorry for the late answer, but I am quite busy at work and I wanted to really think about this...

While I very much like building the Windows and Mac version with one action approach, I do not think that adding dependency to external actions would be good step for small simple cmake application skeleton. I was already quite hesitant to add docker image of my own making that lives outside of the repository to the gitlab-ci.yml file...

But thanks a lot for the contribution, it made me look more on the github actions! Have a good one!

kracejic avatar Feb 17 '20 18:02 kracejic