[BUG] NumberScroll issue on Mac

[ponderstine]

Describe the bug 🐛 I am not able to change the values of a NumberScroll in settings. I have tried scrolling with my MacBook Air trackpad and my Logitech bluetooth mouse which did nothing. When I pressed 'J' or 'K' or Up or Down it or Shift+Up or Shift+Down it would change the highlighted setting to the next setting but would not actually toggle/alter the values of any of the settings themself.

To Reproduce 🐣 Steps to reproduce the behavior:

1. On Python 3.10, Mac OS 10.15.3
2. Go to settings page
3. Try to change value in number scroll with scrollwheel, 'J' and 'K' keys

Expected behavior 🤔 The value in the NumberScroll for the setting should change up or down.

Screenshots 🧐 If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information): 🤖

• OS: Mac OSx 10.15.3
• Python 10.3

Additional context 📝 Need the NumberScrolls to be working so I can test adding a new NumberScroll for a different feature :)

[kraanzu]

I have tried scrolling with my MacBook Air trackpad and my Logitech bluetooth mouse which did nothing

Scroll was a feature in the previous version which i removed in the latest version :)

When I pressed 'J' or 'K' or Up or Down it or Shift+Up or Shift+Down it would change the highlighted setting to the next setting

That's strange...should've properly

Can you run this script and then press keys and send back a screenshot?

from textual.app import App
from textual.widgets import Static


class X(App):
    async def on_mount(self):
        self.text = (
            "Listening for keys. Press any key to log:\n--------------------\n\n"
        )
        self.scratch = Static(self.text)
        await self.view.dock(self.scratch)

    async def on_key(self, event):
        self.text = f"{self.text}Pressed: {event.key}\n"
        await self.scratch.update(self.text)


X.run()

[ponderstine]

When I tried that it printed out the "Listening for keys. Press any key to log:" string and then did not log any additional info when I pressed any keys. I was able to quit the running py3 script with a Ctrl+C interrupt. I tried pressing keys on both my external bluetooth keyboard as well as my built-in macbook keyboard and neither worked. So it sounds like this is more a problem of the app logging my key presses at the right time to trigger the appropriate settings changes?

[kraanzu]

I tried pressing keys on both my external bluetooth keyboard as well as my built-in macbook keyboard and neither worked

Hmmm.. I really don't know what is causing the problem as there are mac users and they don't seem to have a problem with this. Previously you said:

When I pressed 'J' or 'K' or Up or Down it or Shift+Up or Shift+Down it would change the highlighted setting to the next setting

Which means that the keys were getting registered :confused: Idk if this is relatable but have you tried running on some other terminal?

[ponderstine]

I have tried and encountered this error in the zsh for Mac terminal app as well as zsh in the integrated terminal in Vs code.

On Mon, Aug 8, 2022 at 7:42 AM Murli Tawari @.***> wrote:

I tried pressing keys on both my external bluetooth keyboard as well as my built-in macbook keyboard and neither worked

Hmmm.. I really don't know what is causing the problem as there are mac users and they don't seem to have a problem with this. Previously you said:

When I pressed 'J' or 'K' or Up or Down it or Shift+Up or Shift+Down it would change the highlighted setting to the next setting

Which means that the keys were getting registered 😕 Idk if this is relatable but have you tried running on some other terminal?

— Reply to this email directly, view it on GitHub https://github.com/kraanzu/termtyper/issues/46#issuecomment-1208221890, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6MME6SRJGY3AZUFMPHCYTVYEMGLANCNFSM553WMHOQ . You are receiving this because you authored the thread.Message ID: @.***>

--

Very respectfully,

Ponder E. Stine University of Colorado, Boulder @.*** (720) 588-6563

[kraanzu]

I modified the app so this shouldn't be an issue anymore!

Feel free to re-open the issue if it still persists :)