autocomplete icon indicating copy to clipboard operation
autocomplete copied to clipboard

Fix not being able to create newlines in a textarea when `preventSubm…

Open Taitava opened this issue 2 years ago • 1 comments

…itistrue`.

Assume the following:

  1. Autocomplete is used for a textarea element (instead of an input element).
  2. preventSubmit is true.
  3. No autocomplete menu is visible.
  4. User wants to create a newline by pressing the enter key.
  5. Without this change, no newline is inserted, because preventSubmit was too eager to "cancel" the keypress even when no autocomplete menu was open.

Fixes https://github.com/kraaden/autocomplete/issues/72

Taitava avatar Apr 16 '22 10:04 Taitava

@kraaden thank you a lot for merging #90! 🌞 Do you have any comments on this other PR? 🙂

Taitava avatar May 01 '22 04:05 Taitava

@kraaden Any comments, please? 🙂

Taitava avatar Dec 03 '22 06:12 Taitava

This PR is now redundant due to the following commit:

https://github.com/kraaden/autocomplete/commit/cb9356074f9917dd9758f66695a6bd356cf7c24d

denis-taran avatar Jul 23 '23 17:07 denis-taran