Prevent submit on enter only when the autocomplete is displayed

[ofrias]

The preventSubmit setting should only be applied when the autocomplete list is visible. If the enter is pressed while the focus is on the input field the form should be submited.

Sample code:

              var isOpen = containerDisplayed();
              if (selected) {
                  settings.onSelect(selected, input);
                  clear();
              }
              if (preventSubmit && isOpen) {
                  ev.preventDefault();
              }

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Taitava]

I think this is still active, my PR #89 should fix this.

[ofrias]

Unfortunately this issue is not fixed in the current version. You can reproduce it by including the input in a form and pressing enter while the input is focused (without the autocomplete list visible). The browser won't post the form (because of the ev.preventDefault() call) but it should. The sample code is still applicable to the current version and fixes the issue.

[Taitava]

@ofrias Have you tried if #89 fixes it for you?

[ofrias]

Oops, I didn't noticed the PR was not merged in trunk yet. I have just tried and yes, it fixes it too.

[denis-taran]

@ofrias @Taitava

You can now use the following option to prevent form submissions only when an item is selected in autocomplete:

autocomplete({
    ...,
    preventSubmit: PreventSubmit.OnSelect
});

You also need to install the following version:

npm install --save-dev [email protected]

I will close the issue, but if something is not working as expected - let me know.

[Taitava]

@kraaden so, is PR #89 redundant now? 🙂

[denis-taran]

@Taitava Yes, thanks! I closed the PR