kpt icon indicating copy to clipboard operation
kpt copied to clipboard

docker execution: trim "image up to date" lines

Open justinsb opened this issue 1 year ago • 2 comments

This line was recently added to docker's output, and is not part of function execution so should be filtered.

It is also breaking our tests!

justinsb avatar Jan 25 '24 01:01 justinsb

A little confused as to how #4114 is passing tests without this, given that others failed.

/hold

justinsb avatar Jan 25 '24 13:01 justinsb

Looks like it is "random" e.g. https://github.com/kptdev/kpt/pull/4119#issuecomment-1912813388 ... not removing hold until I figure out why it is "random"

justinsb avatar Jan 26 '24 23:01 justinsb

I think it's just random because of races around image pulling.

/hold cancel

/assign @droot

Hopefully this will eliminate a lot of the flakes we're seeing on dependabot PRs.

justinsb avatar Apr 25 '24 12:04 justinsb

/lgtm

/approve

droot avatar Apr 26 '24 03:04 droot