kpt icon indicating copy to clipboard operation
kpt copied to clipboard

porch should support cloning an abstract package even when `fn render` operation fails.

Open droot opened this issue 2 years ago • 3 comments

Sharing more background here:

Ghost application package has a validation function that helps user discover required inputs (hostname in this case) for the package. So cloning ghost package in deployment repo leads to an incomplete package with fn render failing reporting an expected failure.

One can reach this state while editing a package as well (imagine a mis-configuration).

So the expected behavior here is porch should allow saving (and cloning) the package state even in these mis-configuration scenario.

droot avatar Aug 01 '22 19:08 droot

/cc @ChristopherFry

droot avatar Aug 01 '22 19:08 droot

As we discussed earlier, it probably should block Proposing - but allow the cloning and saving. So it has to stay a Draft until it passes all validators.

johnbelamaric avatar Aug 01 '22 19:08 johnbelamaric

As we discussed earlier, it probably should block Proposing - but allow the cloning and saving. So it has to stay a Draft until it passes all validators.

+1.

droot avatar Aug 02 '22 17:08 droot